doc: update server.dropMaxConnection link#61584
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Feb 3, 2026
Merged
doc: update server.dropMaxConnection link#61584nodejs-github-bot merged 1 commit intonodejs:mainfrom
server.dropMaxConnection link#61584nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
aduh95
approved these changes
Jan 30, 2026
| 1. If the process is not running in cluster mode, Node.js will close the connection. | ||
|
|
||
| 2. If the process is running in cluster mode, Node.js will, by default, route the connection to another worker process. To close the connection instead, set \[`server.dropMaxConnection`]\[] to `true`. | ||
| 2. If the process is running in cluster mode, Node.js will, by default, route the connection to another worker process. To close the connection instead, set [`server.dropMaxConnection`][] to `true`. |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| 2. If the process is running in cluster mode, Node.js will, by default, route the connection to another worker process. To close the connection instead, set [`server.dropMaxConnection`][] to `true`. | |
| 2. If the process is running in cluster mode, Node.js will, by default, route the | |
| connection to another worker process. To close the connection instead, set | |
| [`server.dropMaxConnection`][] to `true`. |
cjihrig
approved these changes
Jan 30, 2026
lpinca
approved these changes
Jan 30, 2026
UlisesGascon
approved these changes
Jan 31, 2026
pimterry
approved these changes
Feb 2, 2026
Member
pimterry
left a comment
pimterry
left a comment
There was a problem hiding this comment.
LGTM.
I'd normally land this now since this it's all good to go, but there's an open nit comment here. @samuel871211 that's a totally optional suggestion, so you can either do it if you have a sec or not if you just want to get this done quickly - just let us know and then this can be merged.
Contributor
Author
|
@pimterry |
pimterry
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 9ee3566 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.